Feature #5240

Expose eager-zeroing for vSphere volumes

Added by Dominic Cleal almost 4 years ago. Updated over 3 years ago.

Status:Closed
Priority:Normal
Assigned To:Michael Moll
Category:Compute resources - VMware
Target version:Sprint 28
Difficulty:easy Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/foreman/pull/1708
Story points-
Velocity based estimate-
Release1.6.0Release relationshipAuto

Description

From https://github.com/theforeman/foreman/issues/1382

I quickly hacked app/views/compute_resources_vms/form/vmware/_volume.html.erb so the last lines are:

  <%= checkbox_f f, :thin, {
             :label => _("Thin provision"),
             :class => 'disable-unsupported'},
             "true",
             "false" %>
  <%= checkbox_f f, :eager_zero, {
             :label => "Eager zero",
             :class => 'disable-unsupported',
             :help_inline => remove_child_link("X", f, { :method => :'_delete', :title => _('remove volume'), :class => 'label label-danger disable-unsupported' })},
             "true",
             "false" %>
</div>

Hacked because I didn't bother with the label localization.
It doesn't work out of the box yet because of a bug in fog (https://github.com/fog/fog/issues/2857) but at least with both fixes my SAN admin is happy now :)

Sorry for not supplying a PR. Hope it's trivial enough for someone to do (properly).

Associated revisions

Revision 4c879875
Added by Michael Moll over 3 years ago

fixes #5240 - expose eager-zeroing for vSphere

Revision 39af1c6c
Added by Michael Moll over 3 years ago

fixes #5240 - expose eager-zeroing for vSphere

(cherry picked from commit 4c879875a1ff5b8cd2e506982acc88cbb3d2a0f3)

History

#1 Updated by Michael Moll over 3 years ago

  • Category changed from Compute resources to Compute resources - VMware
  • Assigned To set to Michael Moll
  • Target version set to Sprint 28

#2 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1708 added

#3 Updated by Dominic Cleal over 3 years ago

  • Release set to 1.6.0

#4 Updated by Michael Moll over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF