Actions
Refactor #5936
closed
Unnecessary call to FactName.maximum slows down ENC
Status:
Closed
Priority:
Normal
Assignee:
Category:
External Nodes
Target version:
Description
As explained here: https://github.com/theforeman/foreman/pull/1477
The query "SELECT MAX AS maximum_id, name AS name FROM `fact_names` GROUP BY name ORDER BY fact_names.name" needs to be called only when there are facts to create. Calling it every time slows down every ENC call, especially when the fact_names table is large.
Updated by Dominic Cleal over 10 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
- Translation missing: en.field_release set to 16
Commit message should've been #5936, not #5946.
https://github.com/theforeman/foreman/commit/9e78711ab374d349186b5ba58f2fb8fb58e14ff4
Updated by Bryan Kearney over 10 years ago
- Bugzilla link set to https://bugzilla.redhat.com/show_bug.cgi?id=1107671
Actions