Bug #6085: Virsh provider is not interpreting DHCP netmask correctly - Smart Proxy - Foreman

Actions

Copy link

Bug #6085

closed

Virsh provider is not interpreting DHCP netmask correctly

Added by Lukas Zapletal over 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

DHCP

Target version:

1.6.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

Fixed in Releases:

Found in Releases:

Foreman - Nightly

Red Hat JIRA:

Description

The virsh.rb loadSubnets method was only looking for a definition of a netmask inside the libvirt network XML, despite netmask not being there in case a prefix attribute was defined. netmask and prefix are mutually exclusive by libvirt definition.

Also the ipaddr library has no easy way of retrieving a readable netmask from a prefix, albeit this functionality is provided by the inspect method, in this case the same thing was done as in inspect.

https://github.com/theforeman/smart-proxy/pull/164