Bug #6085

Virsh provider is not interpreting DHCP netmask correctly

Added by Lukas Zapletal almost 4 years ago. Updated almost 4 years ago.

Status:Closed
Priority:Normal
Assigned To:-
Category:DHCP
Target version:Foreman - Sprint 25
Difficulty: Bugzilla link:
Found in release:nightly Pull request:
Story points-
Velocity based estimate-
Release1.6.0Release relationshipAuto

Description

The virsh.rb loadSubnets method was only looking for a definition of a netmask inside the libvirt network XML, despite netmask not being there in case a prefix attribute was defined. netmask and prefix are mutually exclusive by libvirt definition.

Also the ipaddr library has no easy way of retrieving a readable netmask from a prefix, albeit this functionality is provided by the inspect method, in this case the same thing was done as in inspect.

https://github.com/theforeman/smart-proxy/pull/164

Associated revisions

Revision 499c3805
Added by Vincent Kramar almost 4 years ago

fixes #6085 - fixed virsh dhcp provider netmask interpretation

The virsh.rb loadSubnets method was only looking for a definition of
a netmask inside the libvirt network XML, despite netmask not being
there in case a prefix attribute was defined. netmask and prefix are
mutually exclusive by libvirt definition.

Also the ipaddr library has no easy way of retrieving a readable netmask
from a prefix, albeit this functionality is provided by the inspect
method of IPAddr, a monkey-patch "to_mask" was introduced to circument
the original implementation.

History

#1 Updated by Dmitri Dolguikh almost 4 years ago

  • Target version changed from Sprint 24 to Sprint 25

#2 Updated by Anonymous almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF