Bug #6537

Entering a very large number for idle_timeout is unchecked, crashes UI

Added by Dominic Cleal over 3 years ago. Updated over 3 years ago.

Status:Closed
Priority:Normal
Assigned To:Ori Rabin
Category:Settings
Target version:Sprint 26
Difficulty: Bugzilla link:1113349
Found in release: Pull request:https://github.com/theforeman/foreman/pull/1582
Story points-
Velocity based estimate-
Release1.6.0Release relationshipAuto

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1113349
Description of problem:
Idle timeouts can be distracting. Thus, uf a user enters a very large number in the config settings for idle_timeout, there is no bounds testing and the UI crashes.

Version-Release number of selected component (if applicable):

Satellite-6.0.3-RHEL-6-20140625.0

How reproducible:

Steps to Reproduce:
1. In config settings, change the idle_timeout value to something large like "9999999"
2. Begin navigating elsewhere in UI.
3. View results

Actual results:
We're sorry, but something went wrong.

We've been notified about this issue and we'll take a look at it shortly.

In production.log

ArgumentError (year too big to marshal: 192146 UTC):
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/rack/thread_handler_extension.rb:77:in `process_request'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:140:in `accept_and_process_next_request'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:108:in `main_loop'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler.rb:441:in `block (3 levels) in start_threads'

Expected results:
Sane bounds testing of this field (and all others!).

Additional info:


Related issues

Related to Foreman - Bug #7579: Session reset after each page request, idle_timeout set t... Resolved 09/22/2014

Associated revisions

Revision 8e5a869a
Added by Ori Rabin over 3 years ago

Fixes #6537: Entering a very large number for idle_timeout is unchecked, crashes UI

History

#1 Updated by Dominic Cleal over 3 years ago

  • Category set to Settings

#2 Updated by Ori Rabin over 3 years ago

  • Assigned To set to Ori Rabin

#3 Updated by Dominic Cleal over 3 years ago

  • Status changed from New to Assigned
  • Target version set to Sprint 26

#4 Updated by Ori Rabin over 3 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1582 added

#5 Updated by Ori Rabin over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal over 3 years ago

  • Release set to 1.6.0

#7 Updated by Dominic Cleal over 3 years ago

  • Related to Bug #7579: Session reset after each page request, idle_timeout set to zero added

Also available in: Atom PDF