Bug #6585

Fix command exit code handling under Ruby 1.9+

Added by Dominic Cleal over 3 years ago. Updated over 3 years ago.

Status:Closed
Priority:Normal
Assigned To:Aaron Stone
Category:-
Target version:Foreman - Sprint 26
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/smart-proxy/pull/181
Story points-
Velocity based estimate-
Release1.6.0Release relationshipAuto

Description

The exit codes from executed commands aren't retrieved properly, this can be fixed for Ruby 1.9+.

Associated revisions

Revision bbafbc03
Added by Aaron Stone over 3 years ago

fixes #6585 - Update Proxy::Util::CommandTask to handle Ruby 1.8 and 1.9+

In this update, use 'true' and 'false' to test $? return codes 0 and 1, respectively.
In Ruby 1.8.x, the return code from Open3.popen3 is always 0, some errors will not be caught.

History

#1 Updated by Aaron Stone over 3 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

#2 Updated by Dominic Cleal over 3 years ago

  • Assigned To set to Aaron Stone

Also available in: Atom PDF