Proxy::Puppet::Runner incorrectly checked $? for success
|Assigned To:||Aaron Stone|
|Target version:||Foreman - Sprint 26|
|Found in release:||Pull request:||https://github.com/theforeman/smart-proxy/pull/187|
|Velocity based estimate||-|
"The popen test was looking at $?, but it wasn't set by the method under test. Testing Ruby's popen method isn't terribly helpful, it's a built-in.
This replaces the popen test with a test for the shell_command wrapper and adds tests for the other methods in Proxy::Puppet::Runner."