Bug #6911: Unsupported puppet version should be logged as warning only - Kafo - Foreman

Actions

Copy link

Bug #6911

closed

Unsupported puppet version should be logged as warning only

Added by Marek Hulán almost 11 years ago. Updated about 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marek Hulán

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/kafo/pull/104

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

After updating puppet, I get the dreadfull "something went wrong message."

After checking the log there is only the puppet version error...

Can the "Your puppet version does not support progress bar" be set to
WARNING instead of an ERROR? I want to check to output for Successful
messages when deploying foreman automatically in the future.

      Your puppet version does not support progress bar
    Preparing installation Done
       Something went wrong! Check the log for ERROR-level output
       The full log is at /var/log/foreman-installer/foreman-installer.log

    cat /var/log/foreman-installer/foreman-installer.log|grep ERR
    [ERROR 2014-08-04 11:17:28 main]  Your puppet version does not
    support progress bar

    [ INFO 2014-08-04 11:17:44 main] Puppet has finished, bye!
    [ INFO 2014-08-04 11:17:44 main] Executing hooks in group post
    [ INFO 2014-08-04 11:17:44 main] All hooks in group post finished
    [DEBUG 2014-08-04 11:17:44 main] Cleaning /tmp/d20140804-12665-yz1tdt
    [DEBUG 2014-08-04 11:17:44 main] Cleaning /tmp/default_values.yaml

Actions

Copy link

Updated by Marek Hulán almost 11 years ago

Should be easy to change in https://github.com/theforeman/kafo/blob/master/modules/kafo_configure/lib/puppet/parser/functions/add_progress.rb#L43

Actions

Copy link

Updated by Ewoud Kohl van Wijngaarden almost 11 years ago

I'd argue this isn't even a warning but rather a notice.

Actions

Copy link

Updated by Marek Hulán almost 11 years ago

Not that it would matter that much but I think it should be rather warning. I expect to see progress bar but it's impossible on my env. We automatically recover from this error by using some fallback. I understand info/notice as informative message like "Starting installation". What are pros of notice?

Actions

Copy link

Updated by Ewoud Kohl van Wijngaarden almost 11 years ago

I have no strong opinion on this, but I think it mostly depends on the value you add to the progressbar. Personally I think it's not that important and not at all important to see in the log, but the user would want to see it when actually running the installer.

Actions

Copy link

Updated by Dominic Cleal almost 11 years ago

I reckon it should be debug (or whatever level isn't visible) :)

If a user runs an installer with a version of Puppet that doesn't display the progress bar, I don't think we should bother them with the information unless they specifically ask.

Actions

Copy link