Project

General

Profile

Actions

Bug #7378

closed

foreman api v2, GET to /api/v2/puppetclasses/foo/smart_class_parameters returns ALL smart class parameters for all puppet classes, if foo is not a valid puppet class

Added by Petter Hassberg over 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Category:
API
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

When doing an API GET request to /api/v2/puppetclasses/foo it returns a 404 unless there is a puppet class named foo.

If however, the get request is as follows /api/v2/puppetclasses/foo/smart_class_parameters, if foo is not a puppet class, it will list all the smart class parameters for all puppet classes.

this can be I think dangerous.

Actions #1

Updated by Martin Bacovsky over 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Martin Bacovsky
  • Target version set to 1.7.2
Actions #2

Updated by The Foreman Bot over 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/1835 added
  • Pull request deleted ()
Actions #3

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 28
Actions #4

Updated by Anonymous about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF