Project

General

Profile

Actions

Bug #7451

closed

Review whitespace in extracted strings

Added by Dominic Cleal over 9 years ago. Updated over 5 years ago.


Description

Many of the Hammer & Foreman strings contain whitespace at the end, which is causing problems for translators as some are omitting the whitespace and some are leaving it in.

Please review all extracted strings and check whether whitespace is mandatory - if it's part of a sentence, leave it in the string, if it's some sort of UI padding then remove it and append it after the i18n string. If it's not needed, please remove the space.


Related issues 2 (0 open2 closed)

Related to Katello - Bug #22504: Hammer expects improper sentences in testsClosedAndrew Kofink02/02/2018Actions
Related to Katello - Bug #23484: hammer-cli-katello should check string formats in testsClosedAndrew Kofink05/03/2018Actions
Actions #1

Updated by Dominic Cleal over 9 years ago

If I may add this too, it would also be great to review punctuation at the end of strings as this is also very inconsistent. If you type "hammer" with hammer-cli-foreman installed, many of the command descriptions have a trailing "." while others don't. I don't think it should be there.

Actions #2

Updated by Oleh Fedorenko over 6 years ago

  • Status changed from New to Assigned
  • Assignee set to Oleh Fedorenko
Actions #3

Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/258 added
Actions #4

Updated by Oleh Fedorenko over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Oleh Fedorenko over 6 years ago

  • Status changed from Closed to Assigned
Actions #6

Updated by The Foreman Bot over 6 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/265 added
Actions #7

Updated by The Foreman Bot over 6 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/349 added
Actions #8

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/266 added
Actions #9

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/352 added
Actions #10

Updated by Oleh Fedorenko about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions #11

Updated by Andrew Kofink about 6 years ago

  • Related to Bug #22504: Hammer expects improper sentences in tests added
Actions #12

Updated by The Foreman Bot about 6 years ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/268 added
Actions #13

Updated by Andrew Kofink almost 6 years ago

  • Related to Bug #23484: hammer-cli-katello should check string formats in tests added
Actions #14

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/hammer-cli/pull/292 added
Actions

Also available in: Atom PDF