Bug #7451
closedReview whitespace in extracted strings
Description
Many of the Hammer & Foreman strings contain whitespace at the end, which is causing problems for translators as some are omitting the whitespace and some are leaving it in.
Please review all extracted strings and check whether whitespace is mandatory - if it's part of a sentence, leave it in the string, if it's some sort of UI padding then remove it and append it after the i18n string. If it's not needed, please remove the space.
Updated by Dominic Cleal over 10 years ago
If I may add this too, it would also be great to review punctuation at the end of strings as this is also very inconsistent. If you type "hammer" with hammer-cli-foreman installed, many of the command descriptions have a trailing "." while others don't. I don't think it should be there.
Updated by Oleh Fedorenko over 7 years ago
- Status changed from New to Assigned
- Assignee set to Oleh Fedorenko
Updated by The Foreman Bot about 7 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli/pull/258 added
Updated by Oleh Fedorenko about 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset d45d3167ded92f9901ed809b9d801fb532f5924c.
Updated by Oleh Fedorenko about 7 years ago
- Status changed from Closed to Assigned
Updated by The Foreman Bot about 7 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli/pull/265 added
Updated by The Foreman Bot about 7 years ago
- Pull request https://github.com/theforeman/hammer-cli-foreman/pull/349 added
Updated by The Foreman Bot about 7 years ago
- Pull request https://github.com/theforeman/hammer-cli/pull/266 added
Updated by The Foreman Bot about 7 years ago
- Pull request https://github.com/theforeman/hammer-cli-foreman/pull/352 added
Updated by Oleh Fedorenko about 7 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset c836ba963bbb94bb734e6929381ad9f63c5f6d0b.
Updated by Andrew Kofink almost 7 years ago
- Related to Bug #22504: Hammer expects improper sentences in tests added
Updated by The Foreman Bot almost 7 years ago
- Pull request https://github.com/theforeman/hammer-cli/pull/268 added
Updated by Andrew Kofink almost 7 years ago
- Related to Bug #23484: hammer-cli-katello should check string formats in tests added
Updated by The Foreman Bot over 6 years ago
- Pull request https://github.com/theforeman/hammer-cli/pull/292 added