Project

General

Profile

Actions

Refactor #8503

closed

Update ruby_parser and safemode gems

Added by Shlomi Zadok over 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Templates
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

It seems that ruby_parser version > 3.1.1 is breaking with latest safemode (1.2.1)
The issue may be with safemode gem
(tried running:

ruby ~/.rvm/gems/ruby-2.0.0-p576/gems/safemode-1.2.1/demo.rb 
)
and got:
Safemode doesn't allow to access 'constant' on Encoding (Safemode::SecurityError)

which is also breaking our tests when using ruby_parser version 3.6.3

Actions #1

Updated by Dominic Cleal over 9 years ago

  • Category set to Templates
Actions #2

Updated by Anonymous over 9 years ago

  • Status changed from New to Ready For Testing
Actions #3

Updated by The Foreman Bot over 9 years ago

  • Pull request https://github.com/theforeman/foreman/pull/2027 added
  • Pull request deleted ()
Actions #4

Updated by Dominic Cleal over 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #5

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 28
Actions

Also available in: Atom PDF