Feature #8625
closed
salt_puppetrun_cmd config parameter for custom 'puppet.run' command
Description
It would be nice to have an config parameter in /etc/foreman-proxy/settings.d/puppet.yml to set an custom run command for :puppet_provider: salt.
e.g.:salt_puppetrun_cmd: puppet.run agent no-noop
A possible patch i've attached for salt.rb.
Files
Updated by Dominic Cleal over 9 years ago
- Project changed from Salt to Smart Proxy
- Category changed from Smart Proxy to Puppet
Would you mind sending in a pull request for your patch? That's the best (only!) way to get the code into the smart proxy.
It looks about right, I'd suggest the following tweaks:
1. add a commented example to config/settings.d/puppet.yml.example
2. set the default value here instead of using ||: https://github.com/theforeman/smart-proxy/blob/develop/modules/puppet_proxy/puppet_plugin.rb#L6
http://theforeman.org/contribute.html#SubmitPatches has info on contributing, and we're more than happy to help you on #theforeman-dev if needed. Thanks!
Updated by The Foreman Bot over 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/smart-proxy/pull/240 added
- Pull request deleted (
)
Updated by Dominic Cleal over 9 years ago
- Pull request https://github.com/theforeman/smart-proxy/pull/248 added
- Pull request deleted (
https://github.com/theforeman/smart-proxy/pull/240)
Updated by Dominic Cleal about 9 years ago
- Status changed from Ready For Testing to Closed
- Assignee set to Christian Arnold
- translation missing: en.field_release set to 28