Project

General

Profile

Actions

Refactor #8797

closed

Separate style from the HTML in emails.

Added by Shimon Shtein about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
E-Mail
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Email templates contain style information inside the HTML.
It creates clutter in the erb files, and is difficult to track down when changing system style.
Consider using CSS to inline formatter, for example: [[https://www.ruby-toolbox.com/categories/Inline_CSS_for_E-Mail]]


Related issues 2 (1 open1 closed)

Related to Katello - Refactor #12403: Separate style from HTML in e-mailsNew11/05/2015Actions
Related to Foreman - Refactor #15847: URL helpers must be used in mailersClosedDominic Cleal07/27/2016Actions
Actions #1

Updated by Shimon Shtein about 9 years ago

Forgot to mension an example file: app/views/audit_mailer/summary.html.erb

Actions #2

Updated by Dominic Cleal about 9 years ago

  • Category set to E-Mail
Actions #3

Updated by Amir Fefer over 8 years ago

  • Assignee set to Amir Fefer
Actions #4

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2887 added
Actions #5

Updated by Stephen Benjamin over 8 years ago

Actions #6

Updated by Dominic Cleal almost 8 years ago

  • translation missing: en.field_release set to 160
Actions #7

Updated by Amir Fefer almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #8

Updated by Dominic Cleal over 7 years ago

Actions

Also available in: Atom PDF