Bug #9084: net-ldap 0.11 throwing uncaught exceptions with invalid filters - Foreman

Actions

Copy link

Bug #9084

closed

net-ldap 0.11 throwing uncaught exceptions with invalid filters

Added by Dominic Cleal about 10 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Urgent

Assignee:

Dominic Cleal

Category:

Tests

Target version:

1.7.2

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2103

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Some tests are failing since net-ldap 0.11:

Invalid filter syntax. (Net::LDAP::FilterSyntaxInvalidError)
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:674:in `initialize'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:667:in `new'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:667:in `parse'
/usr/local/rvm/gems/ruby-1.9.3-p392@test_develop_pr_core-1/gems/net-ldap-0.11/lib/net/ldap/filter.rb:341:in `construct'
/var/lib/workspace/workspace/test_develop_pr_core/database/sqlite3/ruby/1.9.3/app/models/auth_sources/auth_source_ldap.rb:165:in `validate_ldap_filter'
...
/var/lib/workspace/workspace/test_develop_pr_core/database/sqlite3/ruby/1.9.3/test/unit/auth_source_ldap_test.rb:107:in `block in <class:AuthSourceLdapTest>'

AuthSourceLdapTest.test_0010_the ldap_filter should not exceed the 255 characters
AuthSourceLdapTest.test_0016_invalid ldap_filter fails validation

http://ci.theforeman.org/job/test_develop/1099/