Project

General

Profile

Actions

Bug #9187

closed

Overrideable empty puppet class parameters are still validate their default value

Added by Ewoud Kohl van Wijngaarden about 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Parameters
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

As promised at dinner last night here is the issue :)

With #3260 it became possible to have puppet class parameters that are overrideable but they still validate their default value. That means a parameter with a default value of ${puppet::params::server} and of type boolean will error out even though the default value is not used.


Related issues 4 (0 open4 closed)

Related to Foreman - Feature #3260: Allow puppet parameters to have no default value, but overrideableClosedOri Rabin10/15/2013Actions
Related to Foreman - Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidocClosedShlomi Zadok03/18/2015Actions
Related to Foreman - Bug #11663: Empty lookup value validated even when use_puppet_default is checkedClosedOri Rabin09/02/2015Actions
Has duplicate Foreman - Bug #12878: Default Puppet parameter from Satellite is still validated if "Use Puppet default" is selectedDuplicate12/18/2015Actions
Actions #1

Updated by Ewoud Kohl van Wijngaarden about 9 years ago

  • Related to Feature #3260: Allow puppet parameters to have no default value, but overrideable added
Actions #2

Updated by Dominic Cleal about 9 years ago

  • Category set to Parameters
Actions #3

Updated by Ewoud Kohl van Wijngaarden about 9 years ago

For other users: the workaround is to uncheck the 'use puppet default' checkbox, set a valid default, save, uncheck the checkbox and save again.

Actions #4

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidoc added
Actions #5

Updated by Dominic Cleal almost 9 years ago

I think #9812 might have made this worse in some cases, as it checks for a value to be present...

Actions #6

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2408 added
  • Pull request deleted ()
Actions #7

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release set to 35
Actions #8

Updated by Ori Rabin almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #9

Updated by Dominic Cleal over 8 years ago

  • Related to Bug #11663: Empty lookup value validated even when use_puppet_default is checked added
Actions #10

Updated by Dominic Cleal about 8 years ago

  • Has duplicate Bug #12878: Default Puppet parameter from Satellite is still validated if "Use Puppet default" is selected added
Actions #11

Updated by Bryan Kearney about 8 years ago

  • Bugzilla link set to 1229404
Actions

Also available in: Atom PDF