Bug #9306

User without hostgroup view permissions can't create discover rules

Added by Ori Rabin over 2 years ago. Updated 11 months ago.

Status:Closed
Priority:High
Assigned To:Lukas Zapletal
Category:Discovery plugin
Target version:Plugin 6.0
Difficulty: Pull request:https://github.com/theforeman/foreman_discovery/pull/283
Bugzilla link:
Story points-
Velocity based estimate-

Description

I'm not sure this is a valid set of permissions, I created a user to test something else with these roles:
- Discovery
- Discovery Manager
- Discovery Reader
- View hosts
- Viewer

I then logged in with that user and created a discovery rule,
there was a notice that the rule was created successfully but I couldn't see the rule.
Checking as a user with permissions I can see the rules where created.

Then trying to auto_provision a host doesn't give a notice about no permissions but an error:

undefined method `transaction' for nil:NilClass


Related issues

Related to Discovery - Bug #12256: Rollback during discovered host provisioning errors with ... Closed 10/22/2015
Related to Discovery - Feature #13829: Add view_hosts permission to Discovery Reader Closed 02/22/2016

Associated revisions

Revision 1d7465f6
Added by Lukas Zapletal 11 months ago

Fixes #9306 - added missing view_* permissions

History

#1 Updated by Lukas Zapletal over 2 years ago

#2 Updated by Lukas Zapletal over 2 years ago

  • Category set to Discovery plugin
  • Target version set to Plugin 3.0.0

#3 Updated by Lukas Zapletal over 2 years ago

  • Related to deleted (Tracker #9018: Foreman Discovery 2.1 features)

#4 Updated by Lukas Zapletal about 2 years ago

  • Subject changed from user without hostgroup edit permissions can't see discover rules to User without hostgroup edit permissions can't see discover rules
  • Priority changed from Normal to High
  • Target version deleted (Plugin 3.0.0)

#5 Updated by Lukas Zapletal over 1 year ago

  • Target version set to Plugin 6.0

Bumping prio, we need to test this soon.

#6 Updated by Lukas Zapletal 11 months ago

  • Status changed from New to Closed

Transactions were removed via #12256.

#7 Updated by Lukas Zapletal 11 months ago

  • Related to Bug #12256: Rollback during discovered host provisioning errors with ERF42-8175 and causes post_commit orchestration added

#8 Updated by Lukas Zapletal 11 months ago

  • Related to Feature #13829: Add view_hosts permission to Discovery Reader added

#9 Updated by Lukas Zapletal 11 months ago

  • Subject changed from User without hostgroup edit permissions can't see discover rules to User without hostgroup view permissions can't create discover rules
  • Status changed from Closed to New

Oh permissions are still valid bug, reproduced differently now - hostgroup dropdown is empty.

#10 Updated by The Foreman Bot 11 months ago

  • Status changed from New to Ready For Testing
  • Assigned To set to Lukas Zapletal
  • Pull request https://github.com/theforeman/foreman_discovery/pull/283 added

#11 Updated by Anonymous 11 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF