Bug #9366

Host limit should not be required field

Added by Lukas Zapletal over 2 years ago. Updated about 2 years ago.

Status:Closed
Priority:Normal
Assigned To:Ori Rabin
Category:Discovery plugin
Target version:Plugin 2.0.1
Difficulty: Pull request:https://github.com/theforeman/foreman_discovery/pull/157
Bugzilla link:1190323
Story points-
Velocity based estimate-

Description

host limit is not marked as mandatory variable with (*).Also, If I set the host_limit blank, UI raises error "is not a number". which is misleading.

Description of problem:
On 'Discovery_rule page, host limit should be marked as mandatory variable with (*).

If I set the host_limit blank, UI raises error "is not a number".
which is misleading. I set the host_limit blank, so Ideally UI should raise error: Host_limit can't be blank.

In short Host_limit should be consistent with Priority field.

Version-Release number of selected component (if applicable):
Satellite-6.1.0-RHEL-6-20150205.0
Sat6.1 Beta snap1 compose3

How reproducible:
always

Steps to Reproduce:
1. create a discovery rule with blank host_limit
2.
3.

See the BZ https://bugzilla.redhat.com/show_bug.cgi?id=1190323 for more info and a screenshot.

Valid bug, we should not insist on entering a number and silently default to "0" when not provided (0 - no limit).

Associated revisions

Revision 4c104cf6
Added by Ori Rabin about 2 years ago

Fixes #9366 - host limit for discovery rule defaults to zero

History

#1 Updated by Ori Rabin over 2 years ago

  • Status changed from New to Assigned
  • Assigned To set to Ori Rabin

#2 Updated by The Foreman Bot over 2 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_discovery/pull/157 added

#3 Updated by Lukas Zapletal about 2 years ago

  • Target version set to Plugin 2.0.1

#4 Updated by Ori Rabin about 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF