Bug #9418

No validation on input storage size compute profile

Added by Bryan Kearney about 2 years ago. Updated 8 months ago.

Status:New
Priority:Normal
Assigned To:-
Category:Compute resources
Target version:Team Marek backlog
Difficulty: Bugzilla link:1193306
Found in release: Pull request:
Story points-
Velocity based estimate-

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1193306
Description of problem:
The "Size (G)" field has no validation. You can enter anything you like and it will be stored. I made the mistake to specify 8GB and not 8G. It accepted it, but it failed to provision. IT took quit some time to figure out what was wrong.

Version-Release number of selected component (if applicable):

How reproducible:
Enter anything you like in compute profile -> Storage -> Size.

Steps to Reproduce:
1.
2.
3.

Actual results:
Everything is accepted

Expected results:
Only positive integers should be accepted (the G in the field description "Size (G) already has the unit).

Additional info:

History

#1 Updated by Dominic Cleal about 2 years ago

  • Category set to Compute resources
  • Status changed from New to Need more information
  • Assigned To deleted (Ohad Levy)

Which compute resource is this?

#2 Updated by Bryan Kearney about 2 years ago

I am checking with the reporter

#3 Updated by Tomer Brisker about 1 year ago

  • Category changed from Compute resources to Compute resources - libvirt
  • Status changed from Need more information to New

This is still present in libvirt resource.

#4 Updated by Marek Hulán 8 months ago

  • Category changed from Compute resources - libvirt to Compute resources
  • Target version set to Team Marek backlog

Same thing for oVirt (and probably others) and not only compute profiles but also in host form. The reason is probably the fact that we don't have normal model attribute for that but we serialize volume_attributes as a hash. We should create a non-persistent model for volume and each compute resource should provide mapping methods.

Also available in: Atom PDF