Project

General

Profile

Actions

Bug #9969

closed

N+1 on host[group] edit page

Added by Tomer Brisker almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Database
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

I'm seeing two N+1 queries on the host and hostgroup edit page:

/hosts/aaaa.localdomain/edit
N+1 Query detected
  ConfigGroup => [:puppetclasses]
  Add to your finder: :includes => [:puppetclasses]
N+1 Query method call stack
  /home/tbrisker/foreman/app/views/config_groups/_config_group.html.erb:24:in `block in _app_views_config_groups__config_group_html_erb___4538530726540630601_84201080'
  /home/tbrisker/foreman/app/views/config_groups/_config_group.html.erb:1:in `_app_views_config_groups__config_group_html_erb___4538530726540630601_84201080'
  /home/tbrisker/foreman/app/views/config_groups/_config_groups_selection.html.erb:30:in `block in _app_views_config_groups__config_groups_selection_html_erb___4206814270489975983_79474020'
  /home/tbrisker/foreman/app/views/config_groups/_config_groups_selection.html.erb:28:in `each'
  /home/tbrisker/foreman/app/views/config_groups/_config_groups_selection.html.erb:28:in `_app_views_config_groups__config_groups_selection_html_erb___4206814270489975983_79474020'
  /home/tbrisker/foreman/app/views/puppetclasses/_class_selection.html.erb:6:in `_app_views_puppetclasses__class_selection_html_erb__216266406517635727_65395100'
  /home/tbrisker/foreman/app/views/hosts/_form.html.erb:77:in `block (2 levels) in _app_views_hosts__form_html_erb__2756870351899078531_86890320'
  /home/tbrisker/foreman/app/helpers/layout_helper.rb:274:in `form_for'
  /home/tbrisker/foreman/app/views/hosts/_form.html.erb:8:in `block in _app_views_hosts__form_html_erb__2756870351899078531_86890320'
  /home/tbrisker/foreman/app/models/taxonomy.rb:61:in `block (2 levels) in as_taxonomy'
  /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:147:in `as_location'
  /home/tbrisker/foreman/app/models/taxonomy.rb:60:in `block in as_taxonomy'
  /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:112:in `as_org'
  /home/tbrisker/foreman/app/models/taxonomy.rb:59:in `as_taxonomy'
  /home/tbrisker/foreman/app/views/hosts/_form.html.erb:6:in `_app_views_hosts__form_html_erb__2756870351899078531_86890320'
  /home/tbrisker/foreman/app/views/hosts/edit.html.erb:9:in `_app_views_hosts_edit_html_erb__2313961564929412921_81352140'
  /home/tbrisker/foreman/app/controllers/concerns/application_shared.rb:13:in `set_timezone'
  /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
  /home/tbrisker/foreman/lib/middleware/catch_json_parse_errors.rb:9:in `call'

2015-03-31 14:47:26 [W] user: tbrisker
/hosts/aaaa.localdomain/edit
N+1 Query detected
  Puppetclass => [:lookup_keys]
  Add to your finder: :includes => [:lookup_keys]
N+1 Query method call stack
  /home/tbrisker/foreman/app/helpers/lookup_keys_helper.rb:74:in `overridable_lookup_keys'
  /home/tbrisker/foreman/app/views/puppetclasses/_class_parameters.html.erb:1:in `_app_views_puppetclasses__class_parameters_html_erb__1074257749940126467_77568420'
  /home/tbrisker/foreman/app/views/puppetclasses/_classes_parameters.html.erb:12:in `_app_views_puppetclasses__classes_parameters_html_erb__2520888756816869906_84120220'
  /home/tbrisker/foreman/app/views/hosts/_form.html.erb:92:in `block (2 levels) in _app_views_hosts__form_html_erb__2756870351899078531_86890320'
  /home/tbrisker/foreman/app/helpers/layout_helper.rb:274:in `form_for'
  /home/tbrisker/foreman/app/views/hosts/_form.html.erb:8:in `block in _app_views_hosts__form_html_erb__2756870351899078531_86890320'
  /home/tbrisker/foreman/app/models/taxonomy.rb:61:in `block (2 levels) in as_taxonomy'
  /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:147:in `as_location'
  /home/tbrisker/foreman/app/models/taxonomy.rb:60:in `block in as_taxonomy'
  /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:112:in `as_org'
  /home/tbrisker/foreman/app/models/taxonomy.rb:59:in `as_taxonomy'
  /home/tbrisker/foreman/app/views/hosts/_form.html.erb:6:in `_app_views_hosts__form_html_erb__2756870351899078531_86890320'
  /home/tbrisker/foreman/app/views/hosts/edit.html.erb:9:in `_app_views_hosts_edit_html_erb__2313961564929412921_81352140'
  /home/tbrisker/foreman/app/controllers/concerns/application_shared.rb:13:in `set_timezone'
  /home/tbrisker/foreman/app/models/concerns/foreman/thread_session.rb:32:in `clear_thread'
  /home/tbrisker/foreman/lib/middleware/catch_json_parse_errors.rb:9:in `call'


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #10158: Add new host to fresh installClosedDominic Cleal04/16/2015Actions
Actions #1

Updated by Tomer Brisker almost 9 years ago

  • Description updated (diff)
Actions #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2279 added
  • Pull request deleted ()
Actions #3

Updated by Anonymous almost 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release set to 50
Actions #5

Updated by Dominic Cleal almost 9 years ago

  • Related to Bug #10158: Add new host to fresh install added
Actions #6

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release changed from 50 to 35

Release bumped due to unfixed regression, #10158.

Actions

Also available in: Atom PDF