Bug #9991

ARF Upload fails on first error event if it's client error

Added by Marek Hulán over 2 years ago. Updated about 2 years ago.

Status:ClosedSpent time:-
Priority:Normal
Assigned To:Ondřej Pražák
Category:-
Target version:0.5.0
Difficulty: Bugzilla link:
Found in release: Pull request:https://github.com/theforeman/smart_proxy_openscap/pull/16
Triaged:No
Story points-
Velocity based estimate-

Description

Yesterday we found that during arf report uploading from smart proxy to Foreman the process can fail if Foreman does not respond with 200. This can cause proxy to not upload any other report easily, suppose Foreman responds with 404. This can easily happen if you upload one report from client with wrong certificate or you simply remove a host from Foreman. We should not raise exception in such case just log it and continue with other report.

See
https://github.com/OpenSCAP/smart_proxy_openscap/blob/v0.4.0/lib/smart_proxy_openscap/openscap_lib.rb#L120
https://github.com/OpenSCAP/smart_proxy_openscap/blob/v0.4.0/lib/smart_proxy_openscap/openscap_lib.rb#L127

Associated revisions

Revision c9bb35e0
Added by Ondřej Pražák over 2 years ago

Fixes #9991 - Exceptions not raised, errors only logged

Revision ce0b2da5
Added by Marek Hulán about 2 years ago

Merge pull request #16 from xprazak2/upload-exception

Fixes #9991 - Exceptions not raised, errors only logged

History

#1 Updated by Ondřej Pražák about 2 years ago

  • Assigned To set to Ondřej Pražák

#2 Updated by Ondřej Pražák about 2 years ago

  • Pull request https://github.com/theforeman/smart_proxy_openscap/pull/16 added

#3 Updated by Marek Hulán about 2 years ago

  • Status changed from New to Closed
  • Target version set to 0.5.0
  • % Done changed from 0 to 100

Also available in: Atom PDF