Refactor #10025
Move taxonomy related methods and scopes to Host::Base
Description
Host::Base already deals with taxonomies, but for some reason we define default_scope and other essential taxonomies related methods in Host::Manage descendant class. That can easy lead to duplication and out of sync of other inheriting classes in plugins (e.g. discovery). We should move all taxonomy related code that is not specific for Host::Manage to Host::Base.
Related issues
Associated revisions
Fixes #10025 - move generic taxonomies code to base class
(cherry picked from commit bf75590c49c05dd780df388908598c85fc8f53bd)
Fixes #10025 - move generic taxonomies code to base class
(cherry picked from commit bf75590c49c05dd780df388908598c85fc8f53bd)
Conflicts:
app/models/host/base.rb
app/models/host/managed.rb
History
#1
Updated by Marek Hulán almost 5 years ago
Updated by - Related to Tracker #10022: Taxonomies related issues added
#2
Updated by Marek Hulán almost 5 years ago
- Related to Bug #10005: CVE-2015-1844 - Discovery hosts are not restricted to user taxonomies added
#3
Updated by The Foreman Bot almost 5 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2287 added
- Pull request deleted (
)
#4
Updated by Dominic Cleal almost 5 years ago
Updated by - Related to Bug #9947: CVE-2015-1844 - GET /api/hosts doesn't respect organization/location membership added
#5
Updated by Dominic Cleal almost 5 years ago
- Legacy Backlogs Release (now unused) set to 40
#6
Updated by Marek Hulán almost 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset bf75590c49c05dd780df388908598c85fc8f53bd.
Fixes #10025 - move generic taxonomies code to base class