Bug #10249: externally cancelled pulp tasks are treated as successful - Katello - Foreman

Bug #10249

externally cancelled pulp tasks are treated as successful

Added by Ivan Necas almost 8 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ivan Necas

Category:

Web UI

Target version:

Katello 2.3.0

Difficulty:

Triaged:

Yes

Bugzilla link:

1203402

Pull request:

https://github.com/Katello/katello/pull/5194

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1203402
Description of problem:

Currently restarting pulp_workers will cause any 'stuck' or running tasks to be cancelled. This is fine and expected. The problem is that katello isn't recognizing those as an error, but instead is treating them as successful and continuing normally.

Version-Release number of selected component (if applicable):
6.1.0

How reproducible:
Always

Steps to Reproduce:
1. Start some long process like a content view publish
2. After it has gotten started, but before it finishes kill the pulp workers
3. Watch the task complete successfully, even though some of the pulp tasks were 'cancelled'

note it may take several tries to get this right

Actual results:
dynflow process 'completes' successfully even though some things did not occur

Expected results:
The task should error, and require the user to resume it

Additional info:

Associated revisions

Revision d5ad3e7d (diff)
Added by Ivan Necas almost 8 years ago

Fixes #10249 - treat canceled tasks as errors

This gives the indication that the task was not finished properly and
should be resumed. Without this patch, we always treated it as
success, which is not correct behavior.

Revision fa5013aa
Added by Ivan Necas almost 8 years ago

Merge pull request #5194 from iNecas/issue/10249-cancel-notice

Fixes #10249 - treat canceled tasks as errors