Project

General

Profile

Bug #10254

gettext .edit.po/timestamp files are shipped in the binary gem

Added by Dominic Cleal over 7 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Hammer core
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

The gettext 3.x locale files (.edit.po and timestamp) that were a part of #8980 are in the binary gems for hammer_cli{,_foreman} and should be excluded from the gemspec file list.

I prefer to use a git file list in the gemspec so only version-controlled files are included, or it can subtract those files from the list.


Related issues

Related to Hammer CLI - Feature #8980: Support locale gem 2.1.0Closed2015-01-15
Related to Hammer CLI - Refactor #18439: Remove PO locale files from gem packagesClosed2017-02-09

History

#1 Updated by Dominic Cleal over 7 years ago

#2 Updated by Oleh Fedorenko almost 5 years ago

  • Assignee set to Oleh Fedorenko

#3 Updated by Oleh Fedorenko almost 5 years ago

  • Status changed from New to Assigned

#4 Updated by Oleh Fedorenko almost 5 years ago

  • Related to Refactor #18439: Remove PO locale files from gem packages added

#5 Updated by Oleh Fedorenko almost 5 years ago

  • Status changed from Assigned to Closed
  • Pull request https://github.com/theforeman/hammer-cli/pull/231 added

I think it was fixed within this commit: https://github.com/theforeman/hammer-cli/commit/f1b2e8b67bef81f26894f159171da6f7f55a456b

Suggest to close.

Also available in: Atom PDF