Project

General

Profile

Bug #10355

Import puppetclasses in 1.8 from foreman proxy is executed twice

Added by Zdenek Janda over 6 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

I have upgraded to 1.8 and noticed import puppetclasses takes unusually long. After investigating, i figured out foreman now reads the classes from proxy twice:

217.28.94.7 - - [04/May/2015 13:57:27] "GET /puppet/environments HTTP/1.1" 200 47 0.1897
217.28.94.7 - - [04/May/2015 13:58:12] "GET /puppet/environments/production/classes HTTP/1.1" 200 552093 40.5052
217.28.94.7 - - [04/May/2015 13:59:07] "GET /puppet/environments/testing/classes HTTP/1.1" 200 451083 31.6961
217.28.94.7 - - [04/May/2015 13:59:21] "GET /puppet/environments/common/classes HTTP/1.1" 200 2 0.2879
217.28.94.7 - - [04/May/2015 13:59:56] "GET /puppet/environments/development/classes HTTP/1.1" 200 464984 27.7482
217.28.94.7 - - [04/May/2015 14:00:16] "GET /puppet/environments HTTP/1.1" 200 47 0.1055
217.28.94.7 - - [04/May/2015 14:00:55] "GET /puppet/environments/production/classes HTTP/1.1" 200 552093 31.6023
217.28.94.7 - - [04/May/2015 14:01:49] "GET /puppet/environments/testing/classes HTTP/1.1" 200 451083 25.6590
217.28.94.7 - - [04/May/2015 14:02:08] "GET /puppet/environments/common/classes HTTP/1.1" 200 2 0.3390
217.28.94.7 - - [04/May/2015 14:02:43] "GET /puppet/environments/development/classes HTTP/1.1" 200 464984 28.3970

Apart from this twicefork, would it be possible to trigger update just of one puppet module ? It could be easily scheduled via API on postcommit hook and accelerate new class import to seconds, instead of minutes.


Related issues

Related to Foreman - Feature #8802: Add Turbo links supportClosed2014-12-28

Associated revisions

Revision df8887a9 (diff)
Added by Tomer Brisker over 6 years ago

Fixes #10355 - Prevent turbolinks loading puppetclass import

Revision 7bf6a6bf (diff)
Added by Tomer Brisker over 6 years ago

Fixes #10355 - Prevent turbolinks loading puppetclass import

(cherry picked from commit df8887a9d70a7cdea75928cf0656a00f76c63bd3)

History

#1 Updated by Ohad Levy over 6 years ago

this is one of those cases when turbolinks detect there are new assets and reload the page, the downside is that in order to generate the page it takes very long...

#2 Updated by Ohad Levy over 6 years ago

  • Assignee set to Tomer Brisker

#3 Updated by Dominic Cleal over 6 years ago

#4 Updated by Dominic Cleal over 6 years ago

  • Category changed from Puppet integration to Web Interface
  • Legacy Backlogs Release (now unused) set to 50

#5 Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2371 added
  • Pull request deleted ()

#6 Updated by Anonymous over 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF