Actions
Refactor #10439
closed
Reduce task should be idempotent
Description
If it is a task - it should be idempotent, otherwise, move its code to migrations.
Updated by Dominic Cleal over 9 years ago
- Related to Bug #7505: Trends are not aggregrated added
Updated by Dominic Cleal over 9 years ago
- Translation missing: en.field_release set to 35
Updated by Dominic Cleal over 9 years ago
"I don't have a great way of testing the nightly against the volume of data available in our prod environment, but just looking at the new implementation, it seems to be an improvement in design. However the new rake task does concern me -- iterating through every value change is going to take an extremely long time to run for anyone who has a lot of historical trend data. It should be fine if you're standing up a new instance, but I'm worried about how long that's going to take to run on our prod database."
(https://github.com/theforeman/foreman/pull/2365#issuecomment-101443798)
Updated by The Foreman Bot over 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2379 added
- Pull request deleted (
)
Updated by Shimon Shtein over 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset c27e0f6740aba58765d8b8b3d9ebfc3c9d2cb940.
Actions