Project

General

Profile

Actions

Refactor #10439

closed

Reduce task should be idempotent

Added by Shimon Shtein about 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Trends
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

If it is a task - it should be idempotent, otherwise, move its code to migrations.


Related issues 1 (0 open1 closed)

Related to Foreman - Bug #7505: Trends are not aggregratedClosedShimon Shtein09/17/2014Actions
Actions #1

Updated by Dominic Cleal about 9 years ago

  • Related to Bug #7505: Trends are not aggregrated added
Actions #2

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 35
Actions #3

Updated by Dominic Cleal about 9 years ago

"I don't have a great way of testing the nightly against the volume of data available in our prod environment, but just looking at the new implementation, it seems to be an improvement in design. However the new rake task does concern me -- iterating through every value change is going to take an extremely long time to run for anyone who has a lot of historical trend data. It should be fine if you're standing up a new instance, but I'm worried about how long that's going to take to run on our prod database."

(https://github.com/theforeman/foreman/pull/2365#issuecomment-101443798)

Actions #4

Updated by The Foreman Bot about 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2379 added
  • Pull request deleted ()
Actions #5

Updated by Shimon Shtein about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF