Project

General

Profile

Actions

Bug #10504

closed

customrun was broken and customrun_args is empty threw Nil -> string exception

Added by Dhaivat Pandit almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Puppet
Target version:
Fixed in Releases:
Found in Releases:

Description

puppet_proxy custom run complained with,

E, [2015-05-13T22:02:02.659085 #18294] ERROR -- : Exception 'can't convert Array into String' when executing '["/usr/local/bin/custom_command", nil, ["REDACTED_HOST"]]'

In this case :customrun_args: was empty.

Attached PR fixes this https://github.com/theforeman/smart-proxy/pull/284

Actions #1

Updated by Dominic Cleal almost 9 years ago

  • Category set to Puppet
  • Status changed from New to Ready For Testing
  • Assignee set to Dhaivat Pandit
  • translation missing: en.field_release set to 50
  • Pull request https://github.com/theforeman/smart-proxy/pull/284 added
  • Pull request deleted ()
Actions #2

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release changed from 50 to 56
Actions #3

Updated by Dominic Cleal almost 9 years ago

  • translation missing: en.field_release deleted (56)
Actions #4

Updated by Pieter Hollants almost 8 years ago

I updated Dhaivat's fix for the current code: https://github.com/theforeman/smart-proxy/pull/403

Actions #5

Updated by Dominic Cleal almost 8 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/403 added

Thanks Pieter!

Actions #6

Updated by Pieter Hollants almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #7

Updated by Dominic Cleal almost 8 years ago

  • translation missing: en.field_release set to 141
Actions

Also available in: Atom PDF