Project

General

Profile

Bug #10504

customrun was broken and customrun_args is empty threw Nil -> string exception

Added by Dhaivat Pandit almost 5 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Puppet
Target version:
Difficulty:
Triaged:
Bugzilla link:

Description

puppet_proxy custom run complained with,

E, [2015-05-13T22:02:02.659085 #18294] ERROR -- : Exception 'can't convert Array into String' when executing '["/usr/local/bin/custom_command", nil, ["REDACTED_HOST"]]'

In this case :customrun_args: was empty.

Attached PR fixes this https://github.com/theforeman/smart-proxy/pull/284

Associated revisions

Revision 50cd49b7 (diff)
Added by Pieter Hollants almost 4 years ago

Fixes #10504 - Avoid splitting undefined customrun_args

History

#1 Updated by Dominic Cleal almost 5 years ago

  • Category set to Puppet
  • Status changed from New to Ready For Testing
  • Assignee set to Dhaivat Pandit
  • Legacy Backlogs Release (now unused) set to 50
  • Pull request https://github.com/theforeman/smart-proxy/pull/284 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal almost 5 years ago

  • Legacy Backlogs Release (now unused) changed from 50 to 56

#3 Updated by Dominic Cleal over 4 years ago

  • Legacy Backlogs Release (now unused) deleted (56)

#4 Updated by Pieter Hollants almost 4 years ago

I updated Dhaivat's fix for the current code: https://github.com/theforeman/smart-proxy/pull/403

#5 Updated by Dominic Cleal almost 4 years ago

  • Pull request https://github.com/theforeman/smart-proxy/pull/403 added

Thanks Pieter!

#6 Updated by Pieter Hollants almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 141

Also available in: Atom PDF