Project

General

Profile

Bug #10546

Reduce the number of interfaces duplicates

Added by Julien Pivotto about 6 years ago. Updated about 6 years ago.

Status:
Duplicate
Priority:
Normal
Assignee:
-
Category:
Network
Target version:
-
Difficulty:
easy
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When the mac address of an interface changes, it gets duplicate. Example with a bonding interface which has mac address ff:ff:ff:ff:ff:ff when down. We should handle that in a better way and avoid as much duplicates as possible.


Related issues

Related to Foreman - Bug #10805: VLAN interface attached to bond is wrongly created as BondClosed2015-06-13
Related to Foreman - Bug #10888: duplicate interfaces when using bond deviceClosed2015-06-20
Related to Foreman - Bug #10607: bonding on ubuntu causes foreman to create an interface after each ubuntu server rebootClosed2015-05-26

History

#1 Updated by The Foreman Bot about 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2392 added
  • Pull request deleted ()

#3 Updated by Julien Pivotto about 6 years ago

  • Category set to Network
  • Difficulty set to easy

#4 Updated by Marek Hulán about 6 years ago

This was on purpose because we can't really say whether interface got different mac or there's new one with the same mac. Note that vlans, aliases and bonds has the same mac of physical interface they're attached to. Seems like bonds would need special treatment, other virtual interfaces that are down were not part of facts upload. Could you please upload example of facter output with bond that's down? I think the PR does not solve the issue properly. I'm afraid we don't even import bond interfaces as bonds but generic managed interface.

#5 Updated by Julien Pivotto about 6 years ago

Bond interfaces are imported as bond -- they are recognized by their name in the FactParser. When the bond is down the facter output is the same -- just that the bond mac address is blank.

"This was on purpose because we can't really say whether interface got different mac or there's new one with the same mac. "

My proposal is just to pick the interface with the same mac address and name, if not the interface with the mac address if the mac address is not blank, and then only pick the name.

In Linux the unique identifier for an interface is the name. The mac address can be shared, like you said.

#6 Updated by Marek Hulán about 6 years ago

  • Related to Bug #10805: VLAN interface attached to bond is wrongly created as Bond added

#7 Updated by Marek Hulán about 6 years ago

  • Related to Bug #10888: duplicate interfaces when using bond device added

#8 Updated by Marek Hulán about 6 years ago

  • Status changed from Ready For Testing to Duplicate

I think this will be solved by #10888 and #10607 setting as a duplicate. If you experience the same issue after these two are merged, please reopen.

#9 Updated by Marek Hulán about 6 years ago

  • Related to Bug #10607: bonding on ubuntu causes foreman to create an interface after each ubuntu server reboot added

Also available in: Atom PDF