Project

General

Profile

Bug #10586

When /users/login is used as ErrorDocument for 401 with status=401, it does not provide that status

Added by Jan Pazdziora about 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Authentication
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

This is a followup ti http://projects.theforeman.org/issues/3475 which was closed by https://github.com/theforeman/foreman/pull/1253.

We try to be able to use

ErrorDocument 401 /users/login

and we came to the solution of

ErrorDocument 401 /users/login?status=401

because otherwise the resulting status as produced by render is 200 and Kerberos' Negotiate does not kick in. In pull request https://github.com/theforeman/foreman/pull/1253, we try to handle the parameter status=401 and I thought I've tested it back then but it does not seem to work -- the status of that request is 200.


Related issues

Related to Foreman - Bug #3475: When Foreman URL (/users/login) is used as ErrorDocument target, status is not preservedClosed2013-10-23

Associated revisions

Revision 3196ebaa (diff)
Added by Jan Pazdziora about 7 years ago

fixes #10586 - make the 401 status comparison actually match.

Revision 7f9dd3fa (diff)
Added by Jan Pazdziora about 7 years ago

fixes #10586 - make the 401 status comparison actually match.

(cherry picked from commit 3196ebaa009ca1d79e1330d36a0362b7ca04aade)

History

#1 Updated by Dominic Cleal about 7 years ago

  • Related to Bug #3475: When Foreman URL (/users/login) is used as ErrorDocument target, status is not preserved added

#2 Updated by Dominic Cleal about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Jan Pazdziora
  • Pull request https://github.com/theforeman/foreman/pull/2401 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal about 7 years ago

  • Legacy Backlogs Release (now unused) set to 56

#4 Updated by Jan Pazdziora about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF