Project

General

Profile

Bug #10587

Notification flashes surpressed on subsequent actions

Added by Stephen Benjamin over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Notifications
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:

Description

It seems that when one does something in foreman that should generate a notification flash, and then does it again, the second notification is somehow suppressed.

E.g.

1. Go to Provisioning Templates
2. Build PXE Default
3. Get a notification on success
4. Edit a template
5. Build PXE Default
6. No second notification


Related issues

Related to Foreman - Bug #19479: two-pane notifications are not visibleClosed2017-05-09

Associated revisions

Revision b9df73be (diff)
Added by Ohad Levy over 5 years ago

fixes #19479, #10587, #19500 - two pane notifications are visible

- notification is now inside the content div, allowing two-pane server
responses to include it.
- refactored all notifications to use notification helpers (notice,
warning and error) instead of direct flash manipulation
- also added the usage of flash now via the helpers, and fixed
it in a couple of places it was used incorrectly (mostly clone rendering
which does not redirect at all).
- fixed consisteny to remove trailing dots from toast messages (as it
seems most strings are without dot suffix).
- safer handing if notification div or its data is undefined.

History

#1 Updated by Ohad Levy over 5 years ago

  • Related to Bug #19479: two-pane notifications are not visible added

#2 Updated by The Foreman Bot over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ohad Levy
  • Pull request https://github.com/theforeman/foreman/pull/4513 added

#3 Updated by Ohad Levy over 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal over 5 years ago

  • Category changed from Web Interface to Notifications

#5 Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4523 added

Also available in: Atom PDF