Project

General

Profile

Actions

Refactor #10638

closed

Refactor template full-screen mode so that it can be used for other elements

Added by Tomer Brisker about 9 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Related issues 2 (0 open2 closed)

Related to Foreman - Bug #11466: fullscreen buttons should be have consistent layout throughout the applicationClosedTomer Brisker08/24/2015Actions
Blocks Foreman - Feature #3856: Expandable text areas fro overriden parametersClosedTomer Brisker12/11/2013Actions
Actions #1

Updated by Tomer Brisker about 9 years ago

  • Category set to Web Interface
Actions #2

Updated by Ohad Levy about 9 years ago

I'm not following the issue? do you want to use full screen in other places besides templates? or use the templates with full screen but in some other cases?

I'm assuming you want to reuse ACE (maybe also check if it needs upgrading) in other places besides templates?

Actions #3

Updated by Tomer Brisker about 9 years ago

I want to decouple the full screen button from the ace editor so that any element can be made full-screen (for example, for expanding text fields for #3856).
The goal is to have a sort of "fullscreen-button" helper that will let you make any given element display full screen (might be other uses for this to, for example host console)

Actions #4

Updated by The Foreman Bot about 9 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2409 added
  • Pull request deleted ()
Actions #5

Updated by Anonymous about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #6

Updated by Dominic Cleal about 9 years ago

  • translation missing: en.field_release set to 35
Actions #7

Updated by Dominic Cleal almost 9 years ago

  • Blocks Feature #3856: Expandable text areas fro overriden parameters added
Actions #8

Updated by Tomer Brisker almost 9 years ago

  • Related to Bug #11466: fullscreen buttons should be have consistent layout throughout the application added
Actions

Also available in: Atom PDF