Project

General

Profile

Refactor #10812

Remove require 'fog'

Added by Dominic Cleal about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Plugin (foreman_docker)
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

In #8516 (Foreman 1.9.0) we removed the require 'fog' from core and now only load parts of Fog that we need, e.g. 'fog/libvirt'.

foreman_docker has a require 'fog' call here, which can be removed to give a performance boost: https://github.com/theforeman/foreman-docker/blob/master/lib/foreman_docker/engine.rb#L3


Related issues

Related to Foreman - Refactor #8516: Remove require 'fog' and only load specific providersClosed2014-11-26

Associated revisions

Revision e6b93aec (diff)
Added by Shlomi Zadok about 7 years ago

fixes #10812 - remove require fog from plugin's engine

Revision e6b93aec (diff)
Added by Shlomi Zadok about 7 years ago

fixes #10812 - remove require fog from plugin's engine

History

#1 Updated by Dominic Cleal about 7 years ago

  • Related to Refactor #8516: Remove require 'fog' and only load specific providers added

#2 Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/119 added
  • Pull request deleted ()

#3 Updated by Shlomi Zadok about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF