Project

General

Profile

Bug #10976

Unused IP button does not work anymore

Added by Lukas Zapletal over 7 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Something on the JavaScript side perhaps, because when I click it, I don't see any request being sent to Foreman. Chrome stable.

Nitpick: The "Error generating IP: Not Found" error is being inserted in the field itself on error (e.g. proxy is not reachable). This is not only nice from the UX standpoint, but when you try to create new host with proxy unavaiable and you don't even open the interface form and submit, the IP is kept set to this string, which causes validation error. We should totally leave IP field empty on errors showing this message in a bubble or something.


Related issues

Related to Foreman - Bug #9427: Using "Suggest new" IP button from New Host pages is a no-op on webuiClosed2015-02-18
Related to Foreman - Bug #11596: Error generating IP: Not Found shoud not be in the IP fieldClosed2015-08-28

Associated revisions

Revision 36746b82 (diff)
Added by Tomáš Strachota over 7 years ago

Fixes #10976 - Suggest new ip button does not work

The jQuery selector for finding subnet id didn't find the correct field.

Revision 33fde52b (diff)
Added by Tomáš Strachota over 7 years ago

Fixes #10976 - Suggest new ip button does not work

The jQuery selector for finding subnet id didn't find the correct field.

(cherry picked from commit 36746b82896b15d9cdd8eeb0b8b0d0c322aa4cb8)

History

#1 Updated by Lukas Zapletal over 7 years ago

  • Related to Bug #9427: Using "Suggest new" IP button from New Host pages is a no-op on webui added

#2 Updated by Shimon Shtein over 7 years ago

  • Assignee set to Shimon Shtein

#3 Updated by Dominic Cleal over 7 years ago

  • Legacy Backlogs Release (now unused) set to 35

#4 Updated by Tomáš Strachota over 7 years ago

  • Status changed from New to Assigned
  • Assignee changed from Shimon Shtein to Tomáš Strachota

#5 Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2510 added
  • Pull request deleted ()

#6 Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#7 Updated by Lukas Zapletal about 7 years ago

  • Related to Bug #11596: Error generating IP: Not Found shoud not be in the IP field added

Also available in: Atom PDF