Bug #11140: Reindex needs to handle bad errata and package/packagegroups etc - Katello - Foreman

Bug #11140

Reindex needs to handle bad errata and package/packagegroups etc

Added by Partha Aji over 7 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Justin Sherrill

Category:

Installer

Target version:

Katello 2.3.0

Difficulty:

Triaged:

Yes

Bugzilla link:

1253010

Pull request:

https://github.com/Katello/katello/pull/5417

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

The reindex task assumes that [Katello::Package, Katello::PuppetModule, Katello::Distribution, Katello::PackageGroup, Katello::Erratum] all have an "each" method in the case of on error. This causes an additional error thrown every time indexing one of those items fail. We just need to report the exception at the bulk level in those cases and not try to index one at a time.

Also we need to handle errata that point to repo memberships that do not exist in katello (as in we need to ignore those associations). This can happen either when user directly create/syncs a private repo via pulp-admin OR deletes a repo and for some reason the membership did not get updated.

Associated revisions

Revision 7d353896 (diff)
Added by Partha Aji over 7 years ago

Fixes #11140 - Improved reindex for backend search classes

Prior this commit the reindex task assumed that [Katello::Package,
Katello::PuppetModule, Katello::Distribution, Katello::PackageGroup,
Katello::Erratum] all have an "each" method in the case of on error.
This caused an additional "No Such Method" error thrown every time indexing one of those
items failed.
This error handling has been fixed in this commit

Also included is a fix for Katello::Erattum import_all
We can now handle errata that point to repo memberships that do not
exist in katello (as in we ignore those associations).

This typically happens either when user directly create/syncs a private repo
via pulp-admin (there by it existing in pulp but not katello) OR deletes a repo
and for some reason the repo membership for that errata did not get updated in pulp.

Revision 6ab9d290
Added by Justin Sherrill over 7 years ago

Merge pull request #5417 from jlsherrill/reindex-fixes

Fixes #11140 - Improved reindex for backend search classes