Project

General

Profile

Actions

Bug #11172

closed

Select2 should be initialized explicitly

Added by Marek Hulán over 8 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

After select2 was merge, we saw issues with ajax loaded forms. We have workarounds that initialize select2, destroy it and reinitialize it later. When a poor plugin developer wants have control over forms we don't provide any way how to customize this.

I think we should call initialize select2 only on select fields that have specific class.


Related issues 3 (1 open2 closed)

Related to Foreman - Bug #11171: Select2 does not work with compute profilesClosedShlomi Zadok07/21/2015Actions
Related to Foreman - Bug #11173: Multi-select should be initialized explicitlyNew07/21/2015Actions
Related to Foreman - Feature #10641: Ability to search VmWare networksClosedShlomi Zadok05/28/2015Actions
Actions #1

Updated by Marek Hulán over 8 years ago

  • Related to Bug #11171: Select2 does not work with compute profiles added
Actions #2

Updated by Marek Hulán over 8 years ago

  • Related to Bug #11173: Multi-select should be initialized explicitly added
Actions #3

Updated by Marek Hulán over 8 years ago

  • Description updated (diff)
Actions #4

Updated by Dominic Cleal over 8 years ago

Perhaps a class to exclude it would be easier, and then less likely to cause inconsistencies (because somebody forgot to add a class, or a plugin hasn't done it yet)?

Actions #5

Updated by Marek Hulán over 8 years ago

that would be ideal but I'm not sure about :not pseudo-class support, according to http://caniuse.com/#feat=css-sel3 it seems usable

Actions #6

Updated by Dominic Cleal over 8 years ago

Yeah, and we already use it in places.

Actions #7

Updated by Dominic Cleal over 8 years ago

Actions #8

Updated by Dominic Cleal over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • translation missing: en.field_release set to 35
  • Pull request https://github.com/theforeman/foreman/pull/2592 added
  • Pull request deleted ()
Actions #9

Updated by Shlomi Zadok over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF