Bug #11183
syncing content the second time throws traceback in production.log
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1190121
Description of problem:
syncing content the second time throws traceback in production.log with 500 ISE
Version-Release number of selected component (if applicable):
Beta-Snap1-compose3
How reproducible:
always
Steps to Reproduce:
1. create a docker repo
2. sync content
3. now create another docer repo with same content or re-sync the existing docker repo to find 500ISE message errors in foreman/production.log
Actual results:
[root@yyyy yum.repos.d]# hammer -u admin -p changeme repository synchronize --id 6 --organization-id 1
/usr/lib/ruby/gems/1.8/gems/hammer_cli-0.1.4/lib/hammer_cli/./apipie/../abstract.rb:68: warning: already initialized constant DEFAULT_LABEL_INDENT
[ ] [0%]
Task 4c0130f9-ae18-4ab0-a8d4-801b5d7c6c99: pending
Processing metadata
Could not synchronize the repository:
203: unexpected token at 'NaN,"progress_weight":10}'
Expected results:
Should be handled properly, for scenarios mentioned in step 3) of Reproduce.
Additional info:
Associated revisions
History
#1
Updated by The Foreman Bot over 7 years ago
Updated by - Status changed from New to Ready For Testing
- Pull request https://github.com/Katello/katello/pull/5367 added
- Pull request deleted (
)
#2
Updated by Partha Aji over 7 years ago
Updated by - Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset katello|9cb7ac3c33c84b605602efb83b1076c8aab5006f.
#3
Updated by Eric Helms over 7 years ago
Updated by - Legacy Backlogs Release (now unused) set to 31
- Triaged changed from No to Yes
Fixes #11183 - Fixed NaN sync logic for docker presenters
The docker presenter used to return an NaN for "progress completed"
This confused dynflow while serializing things and raised errors like
""
MultiJson::LoadError: 203: unexpected token at
'NaN,"progress_weight":10}'
`load'
""
This commit fixes that by handling the 0 case.