Project

General

Profile

Bug #11318

HttpDownloads.start_download should have returned CommandTask object

Added by Lukas Zapletal about 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Core
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

To allow joining processes:

      if ::Proxy::HttpDownloads.start_download(data['kernel'], '/tmp/vmlinuz').join != 0
        logger.warn "unable to download kernel - aborting" 
      end
      if ::Proxy::HttpDownloads.start_download(data['initram'], '/tmp/initrd.img').join != 0
        logger.warn "unable to download init RAM disk - aborting" 
      end


Related issues

Related to Discovery - Refactor #12100: Improve image/kernel downloading codeClosed2015-10-08

Associated revisions

Revision 5f7fd34c (diff)
Added by Lukas Zapletal almost 4 years ago

Fixes #11318 - HttpDownloads.start_download returns instance

instead of `true`. Allows to join processes, useful for discovery image
plugin.

History

#1 Updated by The Foreman Bot about 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/310 added
  • Pull request deleted ()

#2 Updated by Anonymous almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

#4 Updated by Lukas Zapletal almost 4 years ago

Also available in: Atom PDF