Project

General

Profile

Bug #11354

Can't set container options if target daemon is docker 1.7.1

Added by Partha Aji about 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugin (foreman_docker)
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1253422
Description of problem:
Unable to set container options if docker daemon package version is 1.7.1.

Version-Release number of selected component (if applicable):
Satellite 6.1.1 (CDN)

How reproducible:
Aways

Steps to Reproduce:
1. Create a new container using the container wizard (don't matter if getting the image from content view or Docker HUB)
2. Set the CPU, CPU share and memory
3. Try to finish the wizard

Actual results:

Expected results:

Additional info:
Manually applied [1]in order to make container creation work, but for the memory and other options another fix is required.

[1] https://github.com/theforeman/foreman-docker/commit/e88059db3a33445f654b199d803e4364662b7eaf#diff-8f6cf17bcdab083ba9adc56132c35f1aR11

Associated revisions

Revision ef7e4271 (diff)
Added by Partha Aji almost 7 years ago

Fixes #11354 - Made the container deal with cpu shares and cpu sets correctly

According to docker remote api 'cpu shares' need to be integers.
However foreman docker sends it a float instead causing a
'cant convert to int64' error. This commit fixes that by ensuring what
gets sent to the container is an integer

Similarly According to docker remote api cpusets need to be strings.
However foreman docker sends it an integer instead causing a
'cant convert to string' error. This commit fixes that by ensuring what
gets sent to the container is an string

Revision ef7e4271 (diff)
Added by Partha Aji almost 7 years ago

Fixes #11354 - Made the container deal with cpu shares and cpu sets correctly

According to docker remote api 'cpu shares' need to be integers.
However foreman docker sends it a float instead causing a
'cant convert to int64' error. This commit fixes that by ensuring what
gets sent to the container is an integer

Similarly According to docker remote api cpusets need to be strings.
However foreman docker sends it an integer instead causing a
'cant convert to string' error. This commit fixes that by ensuring what
gets sent to the container is an string

History

#1 Updated by Partha Aji about 7 years ago

  • Project changed from Katello to Docker
  • Category set to Plugin (foreman_docker)

#2 Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman-docker/pull/122 added
  • Pull request deleted ()

#3 Updated by Partha Aji almost 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF