Bug #11428: External user groups refresh is not case insensitive - Foreman

Bug #11428

External user groups refresh is not case insensitive

Added by Daniel Lobato Garcia over 7 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Daniel Lobato Garcia

Category:

Users, Roles and Permissions

Target version:

1.9.1

Difficulty:

Triaged:

Bugzilla link:

1238442

Pull request:

https://github.com/theforeman/foreman/pull/2621

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

group_list in ldap_fluff returns a list of lowercase LDAP GIDs. https://github.com/theforeman/ldap_fluff/blob/master/lib/ldap_fluff/generic_member_service.rb#L56
When foreman tries to run update_usergroups to refresh the external user groups, it will try to match these lowercase gids with external user group names. However, we don't enforce external user group names to be lowercase. If an external user group contains any capital letter, it will not be synced as it will not match the lowercase GID.

Related issues

Associated revisions

Revision 33d7500a (diff)
Added by Daniel Lobato Garcia over 7 years ago

Fixes #11428 - External user groups refresh shouldn't be case sensitive

group_list in ldap_fluff returns a list of lowercase LDAP GIDs.
When AuthSourceLdap tries to run update_usergroups to refresh the external
user groups, it will try to match these lowercase gids with external user
group names.

However, we don't enforce external user group names to be lowercase.
If an external user group contains any capital letter, it will not be
synced as it will not match the lowercase GID.

This commit makes sure we search for external groups case insensitive,
so we can match LDAP GIDs with external groups names.

Revision e5e62175 (diff)
Added by Daniel Lobato Garcia over 7 years ago

Fixes #11428 - External user groups refresh shouldn't be case sensitive

However, we don't enforce external user group names to be lowercase.
If an external user group contains any capital letter, it will not be
synced as it will not match the lowercase GID.

This commit makes sure we search for external groups case insensitive,
so we can match LDAP GIDs with external groups names.

(cherry picked from commit 33d7500a8d3148b6877d630a72f598f4be06b423)