Project

General

Profile

Bug #11663

Empty lookup value validated even when use_puppet_default is checked

Added by Ori Rabin almost 3 years ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Smart Variables
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Since https://github.com/theforeman/foreman/blob/develop/app/models/lookup_value.rb#L10 was added
adding a matcher with an empty value isn't possible even when checking use_puppet_default.
Workaround for now: put any value, save the smart class parameter, edit it again and check use puppet default.


Related issues

Related to Foreman - Bug #9187: Overrideable empty puppet class parameters are still validate their default valueClosed2015-02-02
Related to Foreman - Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidocClosed2015-03-18

Associated revisions

Revision baa21c79 (diff)
Added by Ori Rabin almost 3 years ago

Fixes #11663 - Empty lookup value not validated when use_puppet_default is checked

Revision 80692275 (diff)
Added by Ori Rabin almost 3 years ago

Fixes #11663 - Empty lookup value not validated when use_puppet_default is checked

(cherry picked from commit baa21c791a8b8a3cbbc9f1a21a1cfe2448730800)

History

#1 Updated by Dominic Cleal almost 3 years ago

  • Related to Bug #9187: Overrideable empty puppet class parameters are still validate their default value added

#2 Updated by Dominic Cleal almost 3 years ago

  • Related to Bug #9812: 'match' and 'value' parameters in override value's create should be required in apidoc added

#3 Updated by Dominic Cleal almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 72

Appears to be a 1.9 regression.

#4 Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2674 added
  • Pull request deleted ()

#5 Updated by Ori Rabin almost 3 years ago

  • Assignee set to Ori Rabin

#6 Updated by Ori Rabin almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF