Project

General

Profile

Bug #11825

Adding template types from plugins doesn't work with taxonomies

Added by Ivan Necas almost 7 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ivan Necas
Category:
Plugin integration
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4890
Fixed in Releases:
Found in Releases:

Description

We hit an issue in foreman_remote_execution, when trying to add has_many
association to taxonomies, after the after_create defined, due to the behavior
described in rails/rails#12180 (comment).

Switching from after_create to before_create (and using `#{association}=` instead of `<<`, just for sure)
fixed the issue for us

Related issues

Blocks Foreman Remote Execution - Bug #11805: error creating organization in assign_default_templatesClosed2015-09-14
Blocks Foreman Remote Execution - Bug #21168: Can't create a locationClosed2017-10-02

Associated revisions

Revision 5ae47829 (diff)
Added by Ivan Necas over 4 years ago

Fixes #11825 - use before_create for template associations

We hit an issue in foreman_remote_execution, when trying to add
has_many association to taxonomies, after the after_create defined,
due to the behavior described in
https://github.com/rails/rails/issues/12180#issuecomment-29543330

History

#1 Updated by Ivan Necas almost 7 years ago

  • Blocks Bug #11805: error creating organization in assign_default_templates added

#2 Updated by The Foreman Bot almost 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2723 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal over 5 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/2723)

PR was closed due to inactivity, but I think from the description it's still valid.

#4 Updated by The Foreman Bot over 4 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ivan Necas
  • Pull request https://github.com/theforeman/foreman/pull/4890 added

#5 Updated by Ivan Necas over 4 years ago

  • Blocks Bug #21168: Can't create a location added

#6 Updated by Ivan Necas over 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#7 Updated by Daniel Lobato Garcia over 4 years ago

  • Legacy Backlogs Release (now unused) set to 296

Also available in: Atom PDF