Bug #11850
closed
DNS error message assumes two nameservers
Description
The error message used by the DNS conflict check to handle DNS resolution failures assumes the domain always has zero or two nameservers. Given the implementation of Domain#nameservers, which can return 0-many, it shouldn't be hardcoded to two.
https://github.com/theforeman/foreman/pull/2680/files#diff-2e08cc169e9a6f52d8ede37144c208acR179
Updated by Dominic Cleal over 9 years ago
- Related to Refactor #11709: Improve DNS conflict timeout handling added
Updated by Lukas Zapletal over 9 years ago
Doesnt our UI force you to enter 0-2?
In the worst case there will be "nil" in the error message, the code works just fine.
Updated by Dominic Cleal over 9 years ago
Lukas Zapletal wrote:
Doesnt our UI force you to enter 0-2?
Domain#nameservers uses SOA and NS records, I think you're thinking of the subnet dns_primary/secondary fields which are different and not used here.
In the worst case there will be "nil" in the error message, the code works just fine.
Yeah, or missing nameservers in the error message. This is why I've filed it as low priority.
Updated by The Foreman Bot over 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2733 added
- Pull request deleted (
)
Updated by Dominic Cleal over 9 years ago
- Assignee set to Lukas Zapletal
- Translation missing: en.field_release set to 63
Updated by Lukas Zapletal over 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 448b447effca3cc273c92739c703d684647ae420.