Project

General

Profile

Actions

Refactor #11858

closed

host_inherited_params logic to get ancestry parameters is duplicated

Added by Daniel Lobato Garcia about 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

host_inherited_params on app/models/host/managed.rb tries to get organization/location/hostgroup parameters, including ancestry.
The logic to do it is exactly the same for all 3 models, so it should be combined somehow to reduce code duplication.

Actions #1

Updated by The Foreman Bot about 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2735 added
  • Pull request deleted ()
Actions #2

Updated by Shlomi Zadok about 9 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal about 9 years ago

  • Category set to Rails
  • Assignee set to Shlomi Zadok
  • Translation missing: en.field_release set to 63
Actions

Also available in: Atom PDF