Project

General

Profile

Bug #11912

Remove deprecated assert_present assert_blank

Added by Daniel Lobato Garcia almost 6 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Rails 4.1 deprecates assert_present and assert_blank as per http://guides.rubyonrails.org/4_1_release_notes.html . We don't use these extensively, so we can afford to remove them and use the recommended assert object.present? and assert object.blank?


Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

Associated revisions

Revision 720c2d7f (diff)
Added by Daniel Lobato Garcia almost 6 years ago

Fixes #11912 - Remove deprecated assert_present assert_blank

Rails 4.1 deprecates assert_present and assert_blank as per
http://guides.rubyonrails.org/4_1_release_notes.html . We don't use
these extensively, so we can afford to remove them and use the
recommended assert object.present? and assert object.blank?

Merging this won't introduce any failures on Rails 3 and it will reduce
the diff between the develop and rails 4 branches

History

#1 Updated by Daniel Lobato Garcia almost 6 years ago

#2 Updated by The Foreman Bot almost 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2751 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 6 years ago

  • Category set to Tests
  • Assignee set to Daniel Lobato Garcia
  • Legacy Backlogs Release (now unused) set to 63

#4 Updated by Daniel Lobato Garcia almost 6 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF