Bug #11921
closed
Features in controller authentication are not loaded correctly if you modify them from plugins
Added by Marek Hulán over 9 years ago.
Updated almost 7 years ago.
Category:
Plugin integration
|
Description
We use add_smart_proxy_filters
helper to configure authentication for requests coming from proxy (usually facts/reports). We pass features of proxies that should be considered as authenticated but since it's on class definition level, it evaluates during load time. If we register new importers that adds new potential feature, they are not re-evaluated. We should use pass Procs and evaluate them during runtime if we need dynamic list.
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2752 added
- Pull request deleted (
)
For reproducers: it happens in development env if something loads v2 hosts controller (e.g. foreman-tasks) because it includes some concern. Then when another plugin registers new fact importer (foreman_chef, or I suppose foreman_salt as well) you won't see it in #require_smart_proxy_or_login among features hence authentication fails.
- Related to Feature #8484: Make SmartProxyAuth concern more useful to plugins added
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
- Translation missing: en.field_release set to 104
Also available in: Atom
PDF