Project

General

Profile

Actions
Copy link

Refactor #11938

closed

Rails 4 - Remove WebMock.allow_net_connect!

Added by Chris Peters almost 10 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Ewoud Kohl van Wijngaarden
Category:
-
Target version:
Katello 4.11.0
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/10814, https://github.com/Katello/katello/pull/10920
Fixed in Releases:
Katello 4.11.0
Found in Releases:
Red Hat JIRA:

Description

/test/support/vcr.rb

Actions
Copy link
 #1

Updated by Chris Peters almost 10 years ago

Actions
Copy link
 #2

Updated by Chris Peters almost 10 years ago

This was added to allow specs related to elasticsearch to pass. When conversion to scope search is complete remove this declaration.

Actions
Copy link
 #3

Updated by The Foreman Bot over 9 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Christine Fouant
  • Pull request https://github.com/Katello/katello/pull/5595 added
Actions
Copy link
 #4

Updated by Eric Helms over 9 years ago

  • Translation missing: en.field_release set to 86
  • Triaged changed from No to Yes
Actions
Copy link
 #5

Updated by Chris Peters over 9 years ago

Chris Peters wrote:

/test/support/vcr.rb

The ability for WebMock to create network requests was enabled to get elasticsearch tests/specs to pass. Once elasticsearch is replaced with scoped search; remove this declaration and ensure tests/specs are still passing.

Actions
Copy link
 #6

Updated by Chris Peters over 9 years ago

Actions
Copy link
 #7

Updated by Christine Fouant over 9 years ago

  • Pull request deleted (https://github.com/Katello/katello/pull/5595)
Actions
Copy link
 #8

Updated by Eric Helms over 9 years ago

  • Translation missing: en.field_release changed from 86 to 143
Actions
Copy link
 #9

Updated by Justin Sherrill almost 9 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Christine Fouant)
  • Translation missing: en.field_release changed from 143 to 114
Actions
Copy link
 #10

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Status changed from New to Closed
  • Triaged set to No
Actions
Copy link
 #11

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Status changed from Closed to New

Actually, I see this is still in the code base.

Actions
Copy link
 #12

Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/Katello/katello/pull/10814 added
Actions
Copy link
 #13

Updated by The Foreman Bot over 1 year ago

  • Fixed in Releases Katello 4.12.0 added
Actions
Copy link
 #14

Updated by Ewoud Kohl van Wijngaarden over 1 year ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link
 #15

Updated by Quinn James over 1 year ago

  • Target version changed from Katello Backlog to Katello 4.11.0
  • Triaged changed from No to Yes
Actions
Copy link
 #16

Updated by Ian Ballou over 1 year ago

  • Fixed in Releases Katello 4.11.0 added
  • Fixed in Releases deleted (Katello 4.12.0)
Actions
Copy link
 #17

Updated by The Foreman Bot over 1 year ago

  • Pull request https://github.com/Katello/katello/pull/10920 added
Actions
Copy link

Also available in: Atom PDF