Project

General

Profile

Actions

Refactor #11938

closed

Rails 4 - Remove WebMock.allow_net_connect!

Added by Chris Peters over 8 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Category:
-
Target version:
Branch:
Difficulty:
Triaged:
Yes

Description

/test/support/vcr.rb

Actions #1

Updated by Chris Peters over 8 years ago

Actions #2

Updated by Chris Peters over 8 years ago

This was added to allow specs related to elasticsearch to pass. When conversion to scope search is complete remove this declaration.

Actions #3

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Christine Fouant
  • Pull request https://github.com/Katello/katello/pull/5595 added
Actions #4

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release set to 86
  • Triaged changed from No to Yes
Actions #5

Updated by Chris Peters over 8 years ago

Chris Peters wrote:

/test/support/vcr.rb

The ability for WebMock to create network requests was enabled to get elasticsearch tests/specs to pass. Once elasticsearch is replaced with scoped search; remove this declaration and ensure tests/specs are still passing.

Actions #6

Updated by Chris Peters over 8 years ago

Actions #7

Updated by Christine Fouant over 8 years ago

  • Pull request deleted (https://github.com/Katello/katello/pull/5595)
Actions #8

Updated by Eric Helms over 8 years ago

  • Translation missing: en.field_release changed from 86 to 143
Actions #9

Updated by Justin Sherrill almost 8 years ago

  • Status changed from Ready For Testing to New
  • Assignee deleted (Christine Fouant)
  • Translation missing: en.field_release changed from 143 to 114
Actions #10

Updated by Ewoud Kohl van Wijngaarden 7 months ago

  • Status changed from New to Closed
  • Triaged set to No
Actions #11

Updated by Ewoud Kohl van Wijngaarden 7 months ago

  • Status changed from Closed to New

Actually, I see this is still in the code base.

Actions #12

Updated by The Foreman Bot 7 months ago

  • Status changed from New to Ready For Testing
  • Assignee set to Ewoud Kohl van Wijngaarden
  • Pull request https://github.com/Katello/katello/pull/10814 added
Actions #13

Updated by The Foreman Bot 7 months ago

  • Fixed in Releases Katello 4.12.0 added
Actions #14

Updated by Ewoud Kohl van Wijngaarden 7 months ago

  • Status changed from Ready For Testing to Closed
Actions #15

Updated by Quinn James 7 months ago

  • Target version changed from Katello Backlog to Katello 4.11.0
  • Triaged changed from No to Yes
Actions #16

Updated by Ian Ballou 6 months ago

  • Fixed in Releases Katello 4.11.0 added
  • Fixed in Releases deleted (Katello 4.12.0)
Actions #17

Updated by The Foreman Bot 4 months ago

  • Pull request https://github.com/Katello/katello/pull/10920 added
Actions

Also available in: Atom PDF