Actions
Bug #11990
closedapp/services/fact_parser.rb does not return all the virtual interfaces
Description
This looks like a bug:
While taking a look into the foreman code, I saw that snippet in app/services/fact_parser.rb
def find_physical_interface(interfaces) interfaces.detect { |int, _| int.to_s !~ FactParser::VIRTUAL_NAMES } end def find_virtual_interface(interfaces) interfaces.detect { |int, _| int.to_s =~ /#{FactParser::BONDS}/ } end
I think this should be
def find_physical_interface(interfaces) interfaces.detect { |int, _| int.to_s !~ FactParser::VIRTUAL_NAMES } end def find_virtual_interface(interfaces) interfaces.detect { |int, _| int.to_s =~ FactParser::VIRTUAL_NAMES } end
Updated by The Foreman Bot about 9 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/2765 added
- Pull request deleted (
)
Updated by Anonymous about 9 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 39912bb3bd13acef35dc6ebb2b785ca8c7748cef.
Updated by Dominic Cleal about 9 years ago
- Translation missing: en.field_release set to 63
Actions