Project

General

Profile

Actions
Copy link

Refactor #12091

closed

Should we disable MethodLength and ClassLength checking on dynflow actions in Katello

Added by David Davis over 9 years ago. Updated over 4 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
David Davis
Category:
-
Target version:
Katello Recycle Bin
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/5782
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

The dynflow actions feel more like procedural or imperative programming than OO programming so I am wondering if it makes sense to disable length checking as it's an issue we keep hitting.

Actions
Copy link
 #1

Updated by Eric Helms about 9 years ago

  • Translation missing: en.field_release set to 114
Actions
Copy link
 #2

Updated by The Foreman Bot almost 9 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/5782 added
Actions
Copy link
 #3

Updated by David Davis almost 9 years ago

  • Status changed from Ready For Testing to Rejected
Actions
Copy link
 #4

Updated by Jonathon Turel over 4 years ago

  • Target version changed from Katello Backlog to Katello Recycle Bin
Actions
Copy link

Also available in: Atom PDF