Project

General

Profile

Bug #12096

Change in alignment of parameters list in puppet class parameters tab of puppet class after checking and unchecking override check box.

Added by Jitendra Yejare almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Description of problem:
Change in alignment of parameters list in puppet class parameters tab of puppet class, after checking and unchecking override check box.

Version-Release number of selected component (if applicable):
foreman-1.10.0-0.develop.201510052033gitb064a42.el7.noarch

How reproducible:
Always

Steps to Reproduce:
1. In Configure -> Classes, click on any puppet class to see the list of parameter in 'Puppet Class Parameter' tab.
2. Click on any parameter in the list to edit it.
3. Check the 'override' checkbox to override the default value and then observe that the Flag image is displayed prior to parameter name in the list.
4. Uncheck the Override button.

Actual results:
The parameter name moves few centimetres to the left in the list. This is applicable for all the parameters in the list.

Expected results:
The alignment should be proper and same for all the parameters in the list.

Allignment in Parameter list.png View Allignment in Parameter list.png 142 KB Jitendra Yejare, 10/08/2015 03:04 AM
Allignment%20in%20parameter%20list

Associated revisions

Revision e33ae202 (diff)
Added by Tomer Brisker almost 4 years ago

Fixes #12096 - Fix layout when removing class parameter override

Removing the override for a smart class parameter removed the flag icon
from the parameter pill. This fixes the layout so the parameter name
doesn't move to the left.
This commit also cleans up the JS code a bit and changes deprecated
jQuery `.attr('disabled',...)` to `.prop('disabled')`.

History

#1 Updated by Tomer Brisker almost 4 years ago

  • Status changed from New to Assigned

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2799 added
  • Pull request deleted ()

#3 Updated by Anonymous almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 71

Also available in: Atom PDF