Project

General

Profile

Refactor #12098

Dangling Fog.unmock! makes compute_resource_vms fail

Added by Daniel Lobato Garcia almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

test/unit/compute_resource_test.rb contains a Fog.mock! without a Fog.unmock!. This causes test/functional/compute_resource_vms_controller_test.rb to fail only when ran through rake test on Rails 4. Fix is as simple as adding the missing unmock!.


Related issues

Related to Foreman - Tracker #3157: Rails 4.1 upgrade tasksClosed2013-09-27

Associated revisions

Revision f8a45ebd (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #12098 - Dangling Fog.mock! makes compute_resource_vms test fail

test/unit/compute_resource_test.rb contains a Fog.mock! without a
Fog.unmock!. This causes
test/functional/compute_resource_vms_controller_test.rb to fail only
when ran through rake test on Rails 4. Fix is as simple as adding the
missing unmock!.

History

#1 Updated by Daniel Lobato Garcia almost 4 years ago

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2796 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 4 years ago

  • Category changed from Rails to Tests
  • Legacy Backlogs Release (now unused) set to 71

#4 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF