Project

General

Profile

Bug #12104

Dropdown menu outside of table cell on All Hosts list

Added by Dominic Cleal about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Since #8800, the dropdown menu to the right of the "Edit" button on the All hosts list appears outside of the table cell it's in for me.

Screenshots taken on Chrome 45.0.2454.93.

Screenshot from 2015-10-08 12-31-47.png View Screenshot from 2015-10-08 12-31-47.png 17.6 KB new screenshot Dominic Cleal, 10/08/2015 07:34 AM
Screenshot from 2015-10-08 12-32-01.png View Screenshot from 2015-10-08 12-32-01.png 15.1 KB old screenshot Dominic Cleal, 10/08/2015 07:34 AM
Screenshot%20from%202015 10 08%2012 31 47 Screenshot%20from%202015 10 08%2012 32 01

Related issues

Related to Foreman - Bug #8800: Table cells should clip with tooltip only if text actually overflowsClosed2014-12-28

Associated revisions

Revision e49381e6 (diff)
Added by Tomer Brisker about 4 years ago

Fixes #12104 - prevent overflow in host list for various locales

The width has to be manually defined for the clipping to work properly. I prefer using percentages
to pixels when relevant so that enlarging the main container will cause the table to maintain
the same ratio (only place I used pixels was for the checkbox that has a fixed size).

The host group name clipping, which is the only column here that isn't automatically clipped
because of the special way in which nested host groups need to be clipped.
The whole clipping problem will be much simpler once we enlarge the entire content with the
Patternfly issue as clipping should almost never occur in most places.

Here are some before & after screenshots, problems were also found in German (buttons too large)
& Japanese (line breaking headers):

Before:
![screenshot from 2015-10-15 16-44-49](https://cloud.githubusercontent.com/assets/1540531/10515536/a56945e0-735c-11e5-8b44-46b79efda98c.png)
![screenshot from 2015-10-15 16-45-24](https://cloud.githubusercontent.com/assets/1540531/10515550/aaf4dd08-735c-11e5-94d5-9880aac12e37.png)

After:
![screenshot from 2015-10-15 16-40-16](https://cloud.githubusercontent.com/assets/1540531/10515562/b75b53d8-735c-11e5-8d8a-f9098cb49154.png)
![screenshot from 2015-10-15 16-41-26](https://cloud.githubusercontent.com/assets/1540531/10515565/b8e84ba2-735c-11e5-98aa-d3af21997e66.png)

History

#1 Updated by Dominic Cleal about 4 years ago

  • Related to Bug #8800: Table cells should clip with tooltip only if text actually overflows added

#2 Updated by Tomer Brisker about 4 years ago

  • Status changed from New to Assigned
  • Assignee set to Tomer Brisker
  • Priority changed from Normal to Low

This is cause by :mark_translated making the button larger.
However I will enlarge the column a bit to make sure there is some space to spare.

#3 Updated by The Foreman Bot about 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2818 added
  • Pull request deleted ()

#4 Updated by Anonymous about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF