Project

General

Profile

Actions

Bug #12109

closed

rails 4 compatibility - user_role validation fix

Added by Tom Caspy over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:
Actions #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2801 added
  • Pull request deleted ()
Actions #2

Updated by Daniel Lobato Garcia over 8 years ago

Description from the PR


in rails 4, owner is not populated when creating a join model
(user.roles << role created a UserRole on the background)
in rails 3, this is not a problem, in rails 4, the presence validation
fails because no owner_id exists nor does an owner exist. at that
moment, there’s no need to do the uniqueness validation, as it’s the
user’s first roles. thus, this fix.

Actions #3

Updated by Dominic Cleal over 8 years ago

  • Category set to Rails
  • Assignee set to Tom Caspy
  • translation missing: en.field_release set to 71
Actions #4

Updated by Tom Caspy over 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF